From 3075bf1a34c0b3cd42acc829a3d6b07141c5dc40 Mon Sep 17 00:00:00 2001 From: Marvin W Date: Thu, 1 Jul 2021 20:50:48 +0200 Subject: [PATCH] Cronet: Don't bundle API for now Fixes #1506 --- play-services-cronet-core/build.gradle | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/play-services-cronet-core/build.gradle b/play-services-cronet-core/build.gradle index 4afa63c9..8b30e62a 100644 --- a/play-services-cronet-core/build.gradle +++ b/play-services-cronet-core/build.gradle @@ -8,7 +8,11 @@ apply plugin: 'maven-publish' apply plugin: 'signing' dependencies { - implementation("org.microg:cronet-api:$cronetVersion") + // TODO: Embedding the API causes random crashes as the Android AOT compiler will link the native implementation to + // out API classes even if embedded by a third-party app that comes with their own API classes. + // Need to find a better way to disable AOT for Cronet. Could be by packaging cronet as it's own apk that is + // embedded in the main APK but only loaded at runtime so that the AOT compiler has no way to become active. + // implementation("org.microg:cronet-api:$cronetVersion") implementation("org.microg:cronet-common:$cronetVersion") implementation("org.microg:cronet-native:$cronetVersion") }