From 9318a9607ce90287a3b22b6ea061ed255216a507 Mon Sep 17 00:00:00 2001 From: "Robin C. Ladiges" Date: Thu, 17 Oct 2024 21:04:27 +0200 Subject: [PATCH 1/5] [workflows] update version releases --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7c6e34a..09df9e5 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -22,7 +22,7 @@ jobs: steps: - name : Checkout - uses : actions/checkout@v3 + uses : actions/checkout@v4 - name : Build artifacts id : build @@ -35,7 +35,7 @@ jobs: id : set-output shell : bash run : | - echo "::set-output name=filename-${{ matrix.emu }}::${{ steps.build.outputs.filename }}" + echo "filename-${{ matrix.emu }}=${{ steps.build.outputs.filename }}" >> $GITHUB_OUTPUT release: needs: build From abebfbaa81e6ad624eb62d4a78c834355a5764d8 Mon Sep 17 00:00:00 2001 From: "Robin C. Ladiges" Date: Mon, 21 Oct 2024 14:58:29 +0200 Subject: [PATCH 2/5] gitignore temporary build file --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index fab39ec..d1917ce 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ +/linkerscripts/symstemp.ld starlight_patch_100/** build100/** romfs stuff/** From ddd2ee241d3e94b97774b41d48bd055274fd8737 Mon Sep 17 00:00:00 2001 From: "Robin C. Ladiges" Date: Tue, 9 Jul 2024 09:01:08 +0200 Subject: [PATCH 3/5] fix: check Ryujinx default profile only on emulators --- source/states/StageSceneStateServerConfig.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/states/StageSceneStateServerConfig.cpp b/source/states/StageSceneStateServerConfig.cpp index 101528d..353c533 100644 --- a/source/states/StageSceneStateServerConfig.cpp +++ b/source/states/StageSceneStateServerConfig.cpp @@ -110,7 +110,7 @@ StageSceneStateServerConfig::StageSceneStateServerConfig(const char *name, al::S void StageSceneStateServerConfig::init() { initNerve(&nrvStageSceneStateServerConfigMainMenu, 0); - #ifdef EMU + #if EMU char ryujinx[0x10] = { 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }; nn::account::Uid user; nn::account::GetLastOpenedUser(&user); From 0a18f616e5a297ca174a762cae63f709c5d9616a Mon Sep 17 00:00:00 2001 From: "Robin C. Ladiges" Date: Thu, 17 Oct 2024 14:40:21 +0200 Subject: [PATCH 4/5] fix: add a reconnect failure delay There are TCP timeouts, but in situations where it fails instantly there would otherwise be no delay. (E.g. firewall rejection, or when in flight mode.) --- source/server/SocketClient.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/server/SocketClient.cpp b/source/server/SocketClient.cpp index 4980415..b3de21e 100644 --- a/source/server/SocketClient.cpp +++ b/source/server/SocketClient.cpp @@ -439,6 +439,8 @@ bool SocketClient::tryReconnect() { if (init(sock_ip, port).isSuccess()) { // call init again Logger::log("Reconnect Successful.\n"); return true; + } else { + nn::os::SleepThread(nn::TimeSpan::FromSeconds(1)); } } From d3dcc7e510fd0b45a085692856a1aaa5bf91bc5d Mon Sep 17 00:00:00 2001 From: "Robin C. Ladiges" Date: Mon, 21 Oct 2024 06:54:17 +0200 Subject: [PATCH 5/5] fix: don't crash when changing the language (only when offline) This change only makes it work when in offline/airplane mode. When connected to a server it still crashes. Likely due to a different part of the code. Thanks to https://github.com/piplup55 for pointing out to me that this worked in old versions. I then tested a few older builds and found out that it started to not work with version `v1.1.0`. Using `git bisect` I was able to find out that commit 34691affb0d0fa3e42f39e524d946b5b83b782b9 introduced the issue. --- include/server/gamemode/GameModeManager.hpp | 1 - 1 file changed, 1 deletion(-) diff --git a/include/server/gamemode/GameModeManager.hpp b/include/server/gamemode/GameModeManager.hpp index 8815b25..e0204fe 100644 --- a/include/server/gamemode/GameModeManager.hpp +++ b/include/server/gamemode/GameModeManager.hpp @@ -11,7 +11,6 @@ class GameModeManager { SEAD_SINGLETON_DISPOSER(GameModeManager) GameModeManager(); - ~GameModeManager(); public: void setMode(GameMode mode);