etc/Sharkey
0
0
Fork 0
mirror of https://activitypub.software/TransFem-org/Sharkey synced 2024-12-19 23:10:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Everything must be async

Browse source 
I feel it's not proper to keep the promises `dismissWarning()` returns unhandled, even if they're infallible, but Hazel and Julia have forced my hand
This commit is contained in:
CenTdemeern1 2024-11-09 02:33:23 +01:00
parent 2305eb9e97
commit 953d7ee254
1 changed files with 21 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
packages/frontend/src/components/SkFlashPlayer.vue
View file

@ -82,16 +82,16 @@ let loadingStatus = ref<string | undefined>(undefined);
let player = ref<PlayerElement | undefined>(undefined);
let ruffleError = ref<string | undefined>(undefined);
function dismissWarning() {
async function dismissWarning() {
playerHide.value = false;
loadRuffle().then(() => {
try {
createPlayer();
loadContent();
} catch (error) {
handleError(error);
}
}).catch(handleError);
try {
await loadRuffle();
// NOTE: I don't like this because this handles a success implicitly but Hazel and Julia have forced my hand
createPlayer();
await loadContent();
} catch (error) {
handleError(error);
}
}
function handleError(error: unknown) {
@ -170,22 +170,25 @@ function createPlayer() {
/**
* @throws If `player.value` is uninitialized.
*/
function loadContent() {
async function loadContent() {
if (player.value === undefined) throw Error('Player is uninitialized.');
ruffleContainer.value?.appendChild(player.value);
loadingStatus.value = i18n.ts._flash.loadingFlashFile;
player.value.load(url.value).then(() => {
try {
await player.value.load(url.value);
loadingStatus.value = undefined;
}).catch(error => {
fetch('https://raw.esm.sh/', {
mode: 'cors',
}).then(() => {
} catch (error) {
try {
await fetch('https://raw.esm.sh/', {
mode: 'cors',
});
// NOTE: I don't like this because this handles a success implicitly but Hazel and Julia have forced my hand
handleError(error); // Unexpected error
}).catch(() => {
} catch (_) {
// Must be CSP because esm.sh should be online if `loadRuffle()` didn't fail
handleError(i18n.ts._flash.cspError);
});
});
}
}
}
function playPause() {