perf(backend): ノート作成時のアンテナ追加パフォーマンスを改善

CHANGELOG.md

@@ -12,6 +12,17 @@
 
 -->
 
+## 13.x.x (unreleased)
+
+### General
+-
+
+### Client
+-
+
+### Server
+- ノート作成時のアンテナ追加パフォーマンスを改善
+
 ## 13.11.2
 
 ### Note

packages/backend/src/core/AntennaService.ts

@@ -91,14 +91,24 @@ export class AntennaService implements OnApplicationShutdown {
 	}
 
 	@bindThis
-	public async addNoteToAntenna(antenna: Antenna, note: Note, noteUser: { id: User['id']; }): Promise<void> {
+	public async addNoteToAntennas(note: Note, noteUser: { id: User['id']; username: string; host: string | null; }): Promise<void> {
-		this.redisClient.xadd(
+		const antennas = await this.getAntennas();
-			`antennaTimeline:${antenna.id}`,
+		const antennasWithMatchResult = await Promise.all(antennas.map(antenna => this.checkHitAntenna(antenna, note, noteUser).then(hit => [antenna, hit] as const)));
-			'MAXLEN', '~', '200',
+		const matchedAntennas = antennasWithMatchResult.filter(([, hit]) => hit).map(([antenna]) => antenna);
-			'*',
+
-			'note', note.id);
+		const redisPipeline = this.redisClient.pipeline();
-		
+
-		this.globalEventService.publishAntennaStream(antenna.id, 'note', note);
+		for (const antenna of matchedAntennas) {
+			redisPipeline.xadd(
+				`antennaTimeline:${antenna.id}`,
+				'MAXLEN', '~', '200',
+				'*',
+				'note', note.id);
+			
+			this.globalEventService.publishAntennaStream(antenna.id, 'note', note);
+		}
+
+		redisPipeline.exec();
 	}
 
 	// NOTE: フォローしているユーザーのノート、リストのユーザーのノート、グループのユーザーのノート指定はパフォーマンス上の理由で無効になっている

packages/backend/src/core/NoteCreateService.ts

@@ -493,14 +493,7 @@ export class NoteCreateService implements OnApplicationShutdown {
 			}
 		});
 
-		// Antenna
+		this.antennaService.addNoteToAntennas(note, user);
-		for (const antenna of (await this.antennaService.getAntennas())) {
-			this.antennaService.checkHitAntenna(antenna, note, user).then(hit => {
-				if (hit) {
-					this.antennaService.addNoteToAntenna(antenna, note, user);
-				}
-			});
-		}
 
 		if (data.reply) {
 			this.saveReply(data.reply, note);