From 4ec6bffca70d66b0067fc12c6598fcd7292f594e Mon Sep 17 00:00:00 2001 From: Hazelnoot Date: Sun, 3 Nov 2024 13:01:04 -0500 Subject: [PATCH] don't suppress errors when Update(Question) or Update(Note) fails --- packages/backend/src/core/activitypub/ApInboxService.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/backend/src/core/activitypub/ApInboxService.ts b/packages/backend/src/core/activitypub/ApInboxService.ts index aba49ddaef..ced8b8dc82 100644 --- a/packages/backend/src/core/activitypub/ApInboxService.ts +++ b/packages/backend/src/core/activitypub/ApInboxService.ts @@ -821,7 +821,7 @@ export class ApInboxService { return await this.create(actor, activity, resolver); } - await this.apQuestionService.updateQuestion(object, actor, resolver).catch(err => console.error(err)); + await this.apQuestionService.updateQuestion(object, actor, resolver); return 'ok: Question updated'; } else if (isPost(object)) { // If we get an Update(Note) for a note that doesn't exist, then create it instead @@ -829,7 +829,7 @@ export class ApInboxService { return await this.create(actor, activity, resolver); } - await this.apNoteService.updateNote(object, actor, resolver).catch(err => console.error(err)); + await this.apNoteService.updateNote(object, actor, resolver); return 'ok: Note updated'; } else { return `skip: Unsupported type for Update: ${getApType(object)} (object ${getNullableApId(object)})`;