From 5f0710a486459ebd620001c6e74899a629eb03ba Mon Sep 17 00:00:00 2001 From: Nils Dagsson Moskopp Date: Tue, 15 Jun 2021 17:33:43 +0200 Subject: [PATCH] Make jukebox accept and play old music records With the introduction of the mcl_jukebox API, all music record items were given new names. Old music record items were aliased, but never worked with the jukebox. Apparently no one tested existing records. By explicitly looking up the item name in minetest.registered_aliases, the jukebox accepts old records, plays them, and gives out new records. --- mods/ITEMS/mcl_jukebox/init.lua | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mods/ITEMS/mcl_jukebox/init.lua b/mods/ITEMS/mcl_jukebox/init.lua index c5bd3d26..cc5e97ee 100644 --- a/mods/ITEMS/mcl_jukebox/init.lua +++ b/mods/ITEMS/mcl_jukebox/init.lua @@ -92,7 +92,9 @@ minetest.register_craft({ }) local play_record = function(pos, itemstack, player) - local name = itemstack:get_name() + local item_name = itemstack:get_name() + -- ensure the jukebox uses the new record names for old records + local name = minetest.registered_aliases[item_name] or item_name if mcl_jukebox.registered_records[name] then local cname = player:get_player_name() if active_tracks[cname] ~= nil then