etc
/
HeavenStudioPlus
mirror of https://github.com/RHeavenStudioPlus/HeavenStudioPlus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed timeline event's not being rendered if their start and end points are outside of the view. 

Thank you to chrislo27 for suggesting a fix to this.
This commit is contained in:
Braedon 2022-02-17 21:57:35 -05:00
parent e45304d5d4
commit a8b5d3ed7f
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Assets/Scripts/LevelEditor/Timeline/Timeline.cs
View File

@ -64,7 +64,7 @@ namespace RhythmHeavenMania.Editor.Track
[SerializeField] private RectTransform TimelineSlider;
[SerializeField] private RectTransform TimelineGridSelect;
[SerializeField] private TMP_Text TimelinePlaybackBeat;
[SerializeField] private RectTransform TimelineContent;
public RectTransform TimelineContent;
[SerializeField] private RectTransform TimelineSongPosLineRef;
[SerializeField] private RectTransform TimelineEventObjRef;
[SerializeField] private RectTransform LayersRect;

11
Assets/Scripts/LevelEditor/Timeline/TimelineEventObj.cs
View File

@ -81,8 +81,17 @@ namespace RhythmHeavenMania.Editor.Track
#region Optimizations
// problem with long objects but im lazy right now
// thank you to @chrislo27 for suggesting the fix for this.
// only renders blocks if they're in view of the timeline viewport
bool visible = rectTransform.IsVisibleFrom(Editor.instance.EditorCamera);
var leftSide = rectTransform.localPosition.x;
var rightSide = leftSide + rectTransform.sizeDelta.x;
var timelineLeftSide = (Timeline.instance.TimelineContent.localPosition.x / 100f) * -1;
var timelineRightSide = timelineLeftSide + 10.563f; // what a magic number, i'm sure I could calculate this but I'm lazy
visible = (rightSide >= timelineLeftSide && leftSide <= timelineRightSide);
if (visible != lastVisible)
{