From 94001c354ce1a9697c0de76f5e119a460b1f908c Mon Sep 17 00:00:00 2001
From: minenice55 <star.elementa@gmail.com>
Date: Sun, 21 Aug 2022 22:05:10 -0400
Subject: [PATCH] some notes

---
 Assets/Scripts/BeatmapFormats/DynamicBeatmap.cs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Assets/Scripts/BeatmapFormats/DynamicBeatmap.cs b/Assets/Scripts/BeatmapFormats/DynamicBeatmap.cs
index ad7c4a00..e2509990 100644
--- a/Assets/Scripts/BeatmapFormats/DynamicBeatmap.cs
+++ b/Assets/Scripts/BeatmapFormats/DynamicBeatmap.cs
@@ -96,6 +96,7 @@ namespace HeavenStudio
             {
                 get
                 {
+                    //TODO: do this checking and conversion on load instead of at runtime
                     Minigames.Minigame game = EventCaller.instance.GetMinigame(datamodel.Split(0));
                     Minigames.GameAction action = EventCaller.instance.GetGameAction(game, datamodel.Split(1));
                     Minigames.Param param = EventCaller.instance.GetGameParam(game, datamodel.Split(1), propertyName);
@@ -215,6 +216,7 @@ namespace HeavenStudio
                     length = entity.length,
                     swing = entity.swing,
                     datamodel = entity.datamodel,
+                    //TODO: only convert properties that actually exist in each GameAction
                     DynamicData = new Dictionary<string, dynamic>()
                     {
                         { "valA", entity.valA },