Trails now work properly - There's still some extra features to be added, however they do work quite nicely

src/main/java/biomesoplenty/client/particle/EntityTrailFX.java

@@ -17,27 +17,27 @@ import net.minecraftforge.fml.client.FMLClientHandler;
 
 public class EntityTrailFX extends EntityFX
 {
-	private static ResourceLocation TEST_TRAIL_LOC = new ResourceLocation("biomesoplenty:textures/particles/test_trail.png");
+	private ResourceLocation trailResource;
-	
     /**The index of the flower to be spawned, values are 0-3*/
 	private int particleIndex;
+	private double startY;
 	
-	public EntityTrailFX(World world, double x, double y, double z) 
+	public EntityTrailFX(World world, double x, double y, double z, String trailName) 
 	{
 		super(world, x, y, z);
 		
+		this.trailResource = new ResourceLocation("biomesoplenty:textures/particles/" + trailName + ".png");
         this.motionX = this.motionY = this.motionZ = 0.0D; //Trail particles should not move
 		this.particleMaxAge = 550;
 		this.particleIndex = this.rand.nextInt(4); //Choose a random index on creation
+		this.startY = y; //Where y coordinate where this particle has started (before it moves downwards with time)
 	}
     
     @Override
     public void renderParticle(WorldRenderer renderer, Entity entity, float partialTicks, float rotX, float rotXZ, float rotZ, float rotYZ, float rotXY)
     {
         // EffectRenderer will by default bind the vanilla particles texture, override with our own
-        FMLClientHandler.instance().getClient().renderEngine.bindTexture(TEST_TRAIL_LOC);
+        FMLClientHandler.instance().getClient().renderEngine.bindTexture(this.trailResource);
-        
-        particleIndex = 1;
         
         //The overall maxU and maxV of the particle sheet is 1.0 (representing 16px)
         float minU = (particleIndex % 2) * 0.5F; //Particles on the left side are 0, right are 0.5
@@ -65,4 +65,13 @@ public class EntityTrailFX extends EntityFX
     {
         return 2;
     }
+    
+    @Override
+    public void onUpdate()
+    {
+        super.onUpdate();
+        
+        this.posY = this.startY - 0.01 * ((float)this.particleAge / (float)this.particleMaxAge);
+        this.prevPosY = this.posY;
+    }
 }

src/main/java/biomesoplenty/common/handler/TrailsEventHandler.java

@@ -8,7 +8,9 @@
 
 package biomesoplenty.common.handler;
 
+import biomesoplenty.api.particle.BOPParticleTypes;
 import biomesoplenty.common.remote.TrailManager;
+import biomesoplenty.core.BiomesOPlenty;
 import net.minecraft.entity.player.EntityPlayer;
 import net.minecraft.util.BlockPos;
 import net.minecraft.util.EnumFacing;
@@ -34,20 +36,28 @@ public class TrailsEventHandler
 		if (event.phase == TickEvent.Phase.START)
 		{
 			EntityPlayer player = (EntityPlayer)event.player;
-			World world = player.worldObj;
-			float groundYOffset = 0.015625F; //Prevents particles from z-fighting with the ground
-			BlockPos playerPos = player.getPosition();
 			
-			if (world.getBlockState(playerPos.down()).getBlock().isSideSolid(world, playerPos.down(), EnumFacing.UP)) //Only place particles on blocks with a solid top
+			//Check if the player has a trail
+			if (TrailManager.trailsMap.containsKey(player.getUniqueID()))
 			{
-				if (player.posX != player.prevPosX || player.posZ != player.prevPosZ) //Particles should only spawn if the player is moving
+			    String trailName = TrailManager.trailsMap.get(player.getUniqueID());
-				{
-					//Makes placement more interesting, scatter slightly on the x and z axis
-					double offsetX = 0.3 - world.rand.nextFloat() * 0.6;
-					double offsetZ = 0.3 - world.rand.nextFloat() * 0.6;
 			    
-					//BiomesOPlenty.proxy.spawnParticle(BOPParticleTypes.PLAYER_TRAIL, player.posX + offsetX, ((int)player.posY) + groundYOffset, player.posZ + offsetZ);	
+			    World world = player.worldObj;
-				}
+			    float groundYOffset = 0.015625F; //Prevents particles from z-fighting with the ground
+			    BlockPos playerPos = player.getPosition();
+
+			    if (world.getBlockState(playerPos.down()).getBlock().isSideSolid(world, playerPos.down(), EnumFacing.UP)) //Only place particles on blocks with a solid top
+			    {
+			        if (player.posX != player.prevPosX || player.posZ != player.prevPosZ) //Particles should only spawn if the player is moving
+			        {
+			            //Makes placement more interesting, scatter slightly on the x and z axis
+			            double offsetX = 0.3 - world.rand.nextFloat() * 0.6;
+			            double offsetZ = 0.3 - world.rand.nextFloat() * 0.6;
+
+			            //Move the particle up by 0.01 on spawn to prevent z-fighting (the trail particles move down with time)
+			            BiomesOPlenty.proxy.spawnParticle(BOPParticleTypes.PLAYER_TRAIL, player.posX + offsetX, ((int)player.posY) + groundYOffset + 0.01, player.posZ + offsetZ, trailName);	
+			        }
+			    }
 			}
 		}
 	}

src/main/java/biomesoplenty/common/remote/TrailManager.java

@@ -9,14 +9,13 @@
 package biomesoplenty.common.remote;
 
 import java.io.BufferedReader;
-import java.io.IOException;
 import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
-import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.HashMap;
 import java.util.UUID;
 
+import biomesoplenty.core.BiomesOPlenty;
 import net.minecraft.util.ResourceLocation;
 
 public class TrailManager 
@@ -25,56 +24,43 @@ public class TrailManager
     
     //private static File cacheDirectory = new File(Minecraft.getMinecraft().fil)
     
-    private static HashMap<UUID, String> trailsMap = new HashMap<UUID, String>();
+    public static HashMap<UUID, String> trailsMap = new HashMap<UUID, String>();
-    private static HashMap<String, ResourceLocation> trailTextures = new HashMap<String, ResourceLocation>();
+    public static HashMap<String, ResourceLocation> trailTextures = new HashMap<String, ResourceLocation>();
     
     public static void retrieveTrails()
     {
-        new TrailChecker().start();
+        try
-    }
-    
-    private static class TrailChecker extends Thread
-    {
-        @Override
-        public void run()
         {
-            try
+            URL url = new URL(REMOTE_TRAILS_FILE);
+            HttpURLConnection connection = (HttpURLConnection)url.openConnection();
+            connection.setRequestProperty("User-Agent", "Mozilla/5.0 (Windows; U; Windows NT 6.0; ru; rv:1.9.0.11) Gecko/2009060215 Firefox/3.0.11 (.NET CLR 3.5.30729)");
+            connection.connect();
+            
+            BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
+
+            String line;
+            
+            while ((line = reader.readLine()) != null)
             {
-                URL url = new URL(REMOTE_TRAILS_FILE);
+                if (line.startsWith("//") || line.isEmpty()) continue;
-                HttpURLConnection connection = (HttpURLConnection)url.openConnection();
-                connection.setRequestProperty("User-Agent", "Mozilla/5.0 (Windows; U; Windows NT 6.0; ru; rv:1.9.0.11) Gecko/2009060215 Firefox/3.0.11 (.NET CLR 3.5.30729)");
-                connection.connect();
                 
-                BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
+                String[] split = line.split(":");
                 
-                String line;
+                trailsMap.put(UUID.fromString(split[0]), split[1]);
-                
+                if (!trailTextures.containsKey(split[1])) trailTextures.put(split[1], null);
-                while ((line = reader.readLine()) != null)
-                {
-                    if (line.startsWith("//") || line.isEmpty()) continue;
-                    
-                    String[] split = line.split(":");
-                    
-                    trailsMap.put(UUID.fromString(split[0]), split[1]);
-                    if (!trailTextures.containsKey(split[1])) trailTextures.put(split[1], null);
-                }
-                
-                reader.close();
-                
-                //Retrieve trail textures
-                for (String trailName : trailTextures.keySet())
-                {
-                    
-                }
             }
-            catch (MalformedURLException e)
+            
+            reader.close();
+            
+            //TODO: Retrieve trail textures
+            for (String trailName : trailTextures.keySet())
             {
-                e.printStackTrace();
+                
-            } 
-            catch (IOException e)
-            {
-                e.printStackTrace();
             }
         } 
+        catch (Exception e)
+        {
+            BiomesOPlenty.logger.warn("There was an issue retrieving trails from remote!");
+        } 
     }
 }

src/main/java/biomesoplenty/core/ClientProxy.java

@@ -8,6 +8,21 @@
 
 package biomesoplenty.core;
 
+import biomesoplenty.api.block.IBOPBlock;
+import biomesoplenty.api.item.BOPItems;
+import biomesoplenty.api.particle.BOPParticleTypes;
+import biomesoplenty.client.particle.EntityDandelionFX;
+import biomesoplenty.client.particle.EntityPixieTrailFX;
+import biomesoplenty.client.particle.EntityTrailFX;
+import biomesoplenty.common.config.MiscConfigurationHandler;
+import biomesoplenty.common.entities.EntityPixie;
+import biomesoplenty.common.entities.EntityWasp;
+import biomesoplenty.common.entities.RenderPixie;
+import biomesoplenty.common.entities.RenderWasp;
+import biomesoplenty.common.entities.projectiles.EntityDart;
+import biomesoplenty.common.entities.projectiles.EntityMudball;
+import biomesoplenty.common.entities.projectiles.RenderDart;
+import biomesoplenty.common.entities.projectiles.RenderMudball;
 import net.minecraft.block.Block;
 import net.minecraft.block.properties.IProperty;
 import net.minecraft.block.state.IBlockState;
@@ -27,13 +42,6 @@ import net.minecraft.util.MathHelper;
 import net.minecraft.util.ResourceLocation;
 import net.minecraftforge.client.model.ModelLoader;
 import net.minecraftforge.fml.client.registry.RenderingRegistry;
-import biomesoplenty.api.block.IBOPBlock;
-import biomesoplenty.api.item.BOPItems;
-import biomesoplenty.api.particle.BOPParticleTypes;
-import biomesoplenty.client.particle.*;
-import biomesoplenty.common.config.MiscConfigurationHandler;
-import biomesoplenty.common.entities.*;
-import biomesoplenty.common.entities.projectiles.*;
 
 public class ClientProxy extends CommonProxy
 {
@@ -104,7 +112,7 @@ public class ClientProxy extends CommonProxy
     }
     
     @Override
-    public void spawnParticle(BOPParticleTypes type, double x, double y, double z)
+    public void spawnParticle(BOPParticleTypes type, double x, double y, double z, Object... info)
     {
         Minecraft minecraft = Minecraft.getMinecraft();
         EntityFX entityFx = null;
@@ -121,7 +129,10 @@ public class ClientProxy extends CommonProxy
                 minecraft.theWorld.spawnParticle(EnumParticleTypes.ITEM_CRACK, x, y, z, MathHelper.getRandomDoubleInRange(minecraft.theWorld.rand, -0.08D, 0.08D), MathHelper.getRandomDoubleInRange(minecraft.theWorld.rand, -0.08D, 0.08D), MathHelper.getRandomDoubleInRange(minecraft.theWorld.rand, -0.08D, 0.08D), new int[] {itemId});
                 return;
             case PLAYER_TRAIL:
-                entityFx = new EntityTrailFX(minecraft.theWorld, x, y, z);
+                if (info.length < 1)
+                    throw new RuntimeException("Missing argument for trail name!");
+                
+                entityFx = new EntityTrailFX(minecraft.theWorld, x, y, z, (String)info[0]);
                 break;
             default:
                 break;

src/main/java/biomesoplenty/core/CommonProxy.java

@@ -18,5 +18,5 @@ public class CommonProxy
     public void registerItemVariantModel(Item item, String name, int metadata) {}
     public void registerNonRenderingProperties(Block block) {}
     public void registerFluidBlockRendering(Block block, String name) {}
-    public void spawnParticle(BOPParticleTypes type, double x, double y, double z) {}
+    public void spawnParticle(BOPParticleTypes type, double x, double y, double z, Object... info) {}
 }